Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming DataTransfer.forEach second argument to mimeType #156431

Closed
alexdima opened this issue Jul 27, 2022 · 0 comments · Fixed by #156479
Closed

Consider renaming DataTransfer.forEach second argument to mimeType #156431

alexdima opened this issue Jul 27, 2022 · 0 comments · Fixed by #156479
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
July 2022

Comments

@alexdima
Copy link
Member

Testing #156223

vscode/src/vscode-dts/vscode.d.ts

Line 10187 in 4372050

forEach(callbackfn: (value: DataTransferItem, key: string, dataTransfer: DataTransfer) => void, thisArg?: any): void;

@mjbvz mjbvz added this to the July 2022 milestone Jul 27, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jul 27, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Jul 27, 2022
@mjbvz
Use clearer parameter name
e541354 
Fixes microsoft#156431
@mjbvz mjbvz mentioned this issue Jul 27, 2022
Merged
@mjbvz mjbvz closed this as completed in be910fd Jul 27, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 27, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Use clearer parameter name mjbvz/vscode
4 participants
@alexdima @rzhao271 @mjbvz @vscodenpa