Screen reader not detected on macOS

[kieferrm]

Testing #167159

Version: 1.74.0-insider
Commit: 8b98917
Date: 2022-11-29T07:07:14.672Z
Electron: 19.1.6
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Darwin arm64 21.6.0
Sandboxed: Yes

Automatic screen reader detection doesn't work for me at all, i.e. in none of the scenarios listed in the test plan item. The only way to get in and out of screen reader mode is to use the command.

[deepak1556]

Synced with @kieferrm and confirmed that the issue also persists with stable on the same setup. Only difference between my setup is the OS version, I am on macOS ventura and the issue is seen on macOS monterey. @isidorn can you test on your device as well to validate this.

[isidorn]

I am on macOS ventura and for me this works just fine - both if I first start screen reader, or first start VS Code Insiders.
The only issue I see is that after reload screen reader is not detected - which should be covered by #167583

fyi @meganrogge since I know you are also on macOS

[meganrogge]

On macOS Ventura, with Insider's already open, I expect to see the status bar entry when I turn VoiceOver on, but do not.

Maybe related - I had just turned off screen reader mode prior to this by answering the question Are you using a screen reader to operate VS Code? No.

voiceOver.mov

[isidorn]

@meganrogge double check your settings.json. Ideally you should not have a editor.accessibilitySupport setting set. If you do and it is set to false that means already expressed you are not using a screen reader.

[meganrogge]

thanks @isidorn it doesn't work for me when I set that to auto either (and it's not present in my settings.json)

[meganrogge]

When I toggle VoiceOver, this line does not get hit even though the value of _accessibilitySupport gets correctly updated in accessibilityService

vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts

Lines 671 to 673 in e8e7adf

	if (event.hasChanged(EditorOption.accessibilitySupport)) {
	this.onScreenReaderModeChange(activeCodeEditor);
	}

I think that's because we don't update the configuration value directly here

vscode/src/vs/platform/accessibility/browser/accessibilityService.ts

Lines 105 to 114 in e8e7adf

	setAccessibilitySupport(accessibilitySupport: AccessibilitySupport): void {
	if (this._accessibilitySupport === accessibilitySupport) {
	return;
	}
	this._accessibilitySupport = accessibilitySupport;
	this._onDidChangeScreenReaderOptimized.fire();
	}

So, we should forward the _onDidChangeScreenReaderOptimized event to editorStatus I think which will cause the status indicator to show up or disappear accordingly

[meganrogge]

heard from @kieferrm that the value in his case is not set correctly. The issue I described is different as it's strictly a UI problem.

[deepak1556]

Runtime issue has been resolved, leaving the issue open for #167960

[meganrogge]

This is working for me, no need for my changes

[rzhao271]

There are still issues on macOS Monterey:

1. 🐛 If one reloads Insiders while still keeping VoiceOver open, detection fails
2. 🐛 If one starts VoiceOver first, detection fails
3. ✅ If one starts Insiders, and then starts VoiceOver, detection works

[deepak1556]

Thanks for testing this extensively! 1) and 2) are not regressions from this issue but behavior that has been existed before. I have opened separate issues to track these. In both the scenarios, the runtime puts the application into a11y mode, its just that our components to indicate the mode is not updated properly.