Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notification when starting on Linux with a different system language #172240

Closed
roblourens opened this issue Jan 24, 2023 · 4 comments
Closed

No notification when starting on Linux with a different system language #172240

roblourens opened this issue Jan 24, 2023 · 4 comments
Assignees
@TylerLeonhardt @rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) linux Issues with VS Code on Linux verified Verification succeeded
Milestone
February 2023

Comments

@roblourens
Copy link
Member

Testing #171890

  • Using Linux with xfce, I changed the language to es_MX.UTF-8
  • Opened code-insiders, no notification about language
@TylerLeonhardt
Copy link
Member

We split based on the . and not the _. Maybe we should do that too. Linux seems to use that a fair bit.

@TylerLeonhardt TylerLeonhardt added this to the January 2023 milestone Jan 24, 2023
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels Jan 24, 2023
@rzhao271
Copy link
Contributor

Another potential issue is that the newer Electron getPreferredSystemLanguages API is currently only being used for Windows.

@rzhao271 rzhao271 added the linux Issues with VS Code on Linux label Jan 24, 2023
@rzhao271 rzhao271 modified the milestones: January 2023, February 2023 Jan 25, 2023
@TylerLeonhardt
Copy link
Member

From what @rzhao271 was showing me, the getPreferredSystemLanguages API should normalize this to es.MX

@rzhao271
Copy link
Contributor

\closedWith 1001c87

@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jan 31, 2023
@rzhao271 rzhao271 mentioned this issue Feb 2, 2023
Merged
rzhao271 added a commit that referenced this issue Feb 2, 2023
@rzhao271
Add more processing for ZH locales (#173167)
15311ad 
Ref #172240
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Feb 3, 2023
@connor4312 connor4312 added the verified Verification succeeded label Feb 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders l10n-platform Localization platform issues (not wrong translations) linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
February 2023
Development

No branches or pull requests
5 participants
@roblourens @connor4312 @TylerLeonhardt @rzhao271 @vscodenpa