Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable markdown formatting in showInformationMessage by default #20595

Closed
hatroman opened this issue Feb 14, 2017 · 8 comments
Closed

Disable markdown formatting in showInformationMessage by default #20595

hatroman opened this issue Feb 14, 2017 · 8 comments
Assignees
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Milestone

Comments

@hatroman
Copy link

I've found an open issue (#6087) about markdown in show*Message. And I assume that this functionality is not implemented yet. But if I try to show message with __(double underscore), for example abc__def, underscore characters will be lost and the rest of the text will be italic. I have not found how to disable this type of formatting

  • VSCode Version: 1.9.1
  • OS Version: macOS Sierra 10.12.3

Steps to Reproduce:

  1. just try window.showInformationMessage('abc__def');
  2. and you'll get abcdef, but def in italic
@hatroman
Copy link
Author

/сс @bpasero

@bpasero
Copy link
Member

bpasero commented Feb 19, 2017

I was not aware we support markdown in the message API.

@bpasero bpasero assigned jrieken and unassigned bpasero Feb 19, 2017
@jrieken
Copy link
Member

jrieken commented Feb 20, 2017

@jrieken jrieken assigned bpasero and unassigned jrieken Feb 20, 2017
@bpasero bpasero added this to the February 2017 milestone Feb 20, 2017
@bpasero
Copy link
Member

bpasero commented Feb 20, 2017

@hatroman we support a subset of formatting for messages, not full markdown:

  • * to turn into bold
  • _ to turn into italics
  • [ and ] to mark links inside the message

You can prefix with \\ to escape.

@bpasero bpasero closed this as completed Feb 20, 2017
@bpasero bpasero added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Feb 20, 2017
@hatroman
Copy link
Author

it would be better if i could choose. Sometimes I have calculated value for message and don't now what kind of symbols it contains. Now I will have to escape every time each message. 😞

@bpasero
Copy link
Member

bpasero commented Feb 21, 2017

That would require new API for extensions and the default cannot be that we disable this formatting, otherwise we break existing extensions.

@hatroman
Copy link
Author

👌 thanks anyway

@jrieken
Copy link
Member

jrieken commented Feb 21, 2017

re #20595 (comment) - we should measure how often that actually happens. We never really documented this and the deal is then that we try to see how is using it, inform them, and change it.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

3 participants