Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make repository signature verification blocking #223942

Closed
isidorn opened this issue Jul 26, 2024 · 5 comments
Closed

Make repository signature verification blocking #223942

isidorn opened this issue Jul 26, 2024 · 5 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 26, 2024

  1. Make repository signature blocking on Windows and Mac
  2. Make repository signature blocking on Linux

fyi @joaomoreno

@isidorn isidorn added the extensions Issues concerning extensions label Jul 26, 2024
@isidorn isidorn added this to the August 2024 milestone Jul 26, 2024
@sandy081 sandy081 added the feature-request Request for new features or functionality label Jul 29, 2024
@sandy081
Copy link
Member

Using dat from last 2 stable version (1.91, 1.92)

Non Linux Platforms has 99.9% verification success rate

Image

Whereas Linux platform has 94.4% success rate and 5.5% unknown errors

Image

Here is the classification of Unknown Errors in Linux

Image

83.1% are SIGSYS errors - Which needs further investigation.

Here is my proposal

  1. Make repository signature blocking in Non Linux Platforms
  2. Investigate in parallel SIGSYS error first and other errors in Linux
  3. Enable repository signature blocking in Linux platform once we fixed above errors.

@sandy081 sandy081 modified the milestones: August 2024, September 2024 Aug 23, 2024
@isidorn
Copy link
Contributor Author

isidorn commented Aug 30, 2024

This proposal makes a lot of sense to me. Thank you for looking into the data, and let me know if I can help in any way with 2.

@sandy081
Copy link
Member

@isidorn Can you please verify this? I will share steps on the Slack.

@isidorn
Copy link
Contributor Author

isidorn commented Sep 23, 2024

This works fine. Adding verified label

@sandy081 do we have a follow-up item to track the doc writing. Since the current Learn More link leads to https://builds.code.visualstudio.com/builds/exploration

Image

@isidorn isidorn added the verified Verification succeeded label Sep 23, 2024
@sandy081
Copy link
Member

Created a placeholder issue - microsoft/vscode-docs#7623 - will update the details/

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants