Breakpoints: space to check / uncheck checboxes looses keyboard focus

[AccessibilityTestingTeam-TCS]

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
MAS Violated : MAS 2.4.3
Tool Used : Keyboard

Repro Steps:

1. Launch VS Code.
2. Navigate to Activity Bar and select "View Debug "(Cntrl+Shift+D) button.
3. Navigate to "All Exceptions" and "User Handled Exceptions" checkboxes in "Breakpoints" section.
4. Check/Uncheck checkboxes and use "Tab" each time to focus them.

Actual:
Keyboard focus does not remain on the checkbox when any state is changed. "Tab" is needed to bring back checkbox on focus for first checkbox and for second several tabs are used to bring back focus.

Expected:
Keyboard focus should remain on the checkbox on which any state change action is performed.

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
The keyboard only users will find difficulty in navigating between these checkboxes since they would need to "Tab" again and again to bring focus back to same control once their states are changed.

MAS Reference:
MAS 2.4.3 - https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={0de7fbe1-ad7e-48e5-bcbb-8d986691e2b9}

Attachment For Reference:
A11y_VSCode_ViewDebug_Keyboard_CheckboxFocus.pptx

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• [Accessibility]A11y_VSCode_ViewSearch_ScreenReader: NVDA does not read the state of the checkbox as soon as any action is performed and also focus moves to start of the edit field present. (#52274)
• Monokai button focus color is too similar to checkbox enabled border color (#48855)
• [Accessibility]A11y_VSCode_WelcomeScreen_Keyboard: Keyboard focus does not remain on the same button(from which popup appears) once the popup is closed. (#51976)

[isidorn]

The issue here is that pressing Tab focuses the checkbox, it should never focus the checbox since pressing space on the breakpoint actually checks / unchecks the checkbox.
I partially fixed this by setting a "tabindex"=-1 on the checkbox. However still only the first tab focuses the checkbox. Not sure how to work around this and why is the checkbox getting focus even though it should not.
@bpasero @joaomoreno let me know if you have some ideas on how to tackle

[isidorn]

@bpasero @joaomoreno ping for ideas and help

[bpasero]

@isidorn I do not understand why you can tab into the checkbox even though tabindex=-1 is set, and I could not find any documentation why this would not work :-/

[isidorn]

@bpasero thanks for trying
@bvancea might you know? :)

[isidorn]

Ok after some investigation it seems like the issue is here

The list queries for the element that has the tabIndex property however it should respect if tabIndex is set to -1.
@joaomoreno I have pushed 7a629db to address this