Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show notification when editing settings in UI for the first time #57033

Closed
roblourens opened this issue Aug 22, 2018 · 0 comments · Fixed by #57165
Closed

Show notification when editing settings in UI for the first time #57033

roblourens opened this issue Aug 22, 2018 · 0 comments · Fixed by #57165
Assignees
@roblourens
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2018

Comments

@roblourens
Copy link
Member

To avoid user confusion about whether they need to explicitly save changes in the settings UI, we can show a notification the first time a user edits a setting in the UI.

Just something like "Changes to settings are saved automatically".

@stevencl
@bpasero
@roblourens roblourens added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Aug 22, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 22, 2018
@roblourens roblourens self-assigned this Aug 22, 2018
@roblourens roblourens mentioned this issue Aug 24, 2018
Closed
38 tasks
@JacksonKearl JacksonKearl mentioned this issue Aug 24, 2018
Merged
9 tasks
roblourens added a commit to JacksonKearl/vscode that referenced this issue Aug 25, 2018
@roblourens
microsoft#57033 don't show notification on cmd+s
367d0ad
@roblourens roblourens added the verification-needed Verification of issue is requested label Aug 28, 2018
@jrieken jrieken added the verified Verification succeeded label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

Successfully merging a pull request may close this issue.

Settings tweaks JacksonKearl/vscode
2 participants
@roblourens @jrieken