Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet CSS # character #65464

Closed
kamliuk opened this issue Dec 20, 2018 · 11 comments · Fixed by microsoft/vscode-emmet-helper#46
Closed

Emmet CSS # character #65464

kamliuk opened this issue Dec 20, 2018 · 11 comments · Fixed by microsoft/vscode-emmet-helper#46
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues good first issue Issues identified as good for first-time contributors verified Verification succeeded
Milestone

Comments

@kamliuk
Copy link

kamliuk commented Dec 20, 2018

  • VSCode Version: 1.30.1
  • OS Version: Windows 10 Pro x64

Emmet doesn't works correct after trying to type character #.

Steps to Reproduce:

  1. Type bd1#s.
  2. Press Tab.

Emmet must type border: 1px #000 solid;, but it doesn't.

emmet-css

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Dec 20, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@kamliuk kamliuk changed the title Emmet CSS color Emmet CSS # character Dec 20, 2018
@octref
Copy link
Contributor

octref commented Dec 20, 2018

Is this a valid emmet abbreviation? Can you point me to the docs?

@octref octref added info-needed Issue requires more information from poster emmet Emmet related issues and removed new release labels Dec 20, 2018
@kamliuk
Copy link
Author

kamliuk commented Dec 21, 2018

https://docs.emmet.io/css-abbreviations/

Yes, check the first paragraph in Color values section. There is similar expression: bd5#0s. It does not works too in the editor.

@octref octref added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Dec 21, 2018
@octref octref added this to the Backlog milestone Dec 21, 2018
@octref
Copy link
Contributor

octref commented Dec 21, 2018

OK, it seems to work that way in Atom...

@RiodeJaneiroo
Copy link

Please make a normal "emmet" in css files.
When i write dib, then should write display: inline-block and now it is writing box-decoration-break:
and so with many rules.

@octref
Copy link
Contributor

octref commented Feb 16, 2019

@RiodeJaneiroo Are you on insider version by any chance? It seems this is broken in Insiders but not 1.31.1.

@RiodeJaneiroo
Copy link

RiodeJaneiroo commented Feb 16, 2019

@octref no, stable version. This setting helped me:

{ "key": "tab", "command": "-acceptSelectedSuggestion" }

@Friksel
Copy link

Friksel commented Jun 5, 2019

This issue was already started in december 2018 on version 1.30.1.
It's now 5th of june 2019 and we're in version 1.35.0 of VS Code, but unfortunately emmet abbreviations like bd1#s (for border with a color) still don't work in VS Code.

It would be nice if this could get some love and attention, because these css emmet abbreviation really speed up the workflow of a front-end developer a lot and so are very welcome! Thanks!

@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Oct 22, 2020
@rzhao271 rzhao271 modified the milestones: Backlog, November 2020 Nov 16, 2020
@rzhao271
Copy link
Contributor

rzhao271 commented Jan 6, 2021

I have confirmed that vscode-emmet-helper can now expand the abbreviation properly, but I think there's still an issue with some code in this repo, so I can't call this fixed yet.

@rzhao271 rzhao271 modified the milestones: January 2021, February 2021 Jan 22, 2021
@rzhao271 rzhao271 added the good first issue Issues identified as good for first-time contributors label Feb 5, 2021
jeanp413 added a commit to jeanp413/vscode-emmet-helper that referenced this issue Feb 8, 2021
@jeanp413
Copy link
Contributor

jeanp413 commented Feb 8, 2021

Created a PR microsoft/vscode-emmet-helper#46 fixing this

rzhao271 pushed a commit to microsoft/vscode-emmet-helper that referenced this issue Feb 9, 2021
@Friksel
Copy link

Friksel commented Feb 10, 2021

Created a PR microsoft/vscode-emmet-helper#46 fixing this

Thanks!

@aeschli aeschli added the verified Verification succeeded label Feb 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues good first issue Issues identified as good for first-time contributors verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants