Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL renderer isn't hot swappable #85970

Closed
Tyriar opened this issue Dec 2, 2019 · 2 comments · Fixed by #106203
Closed

WebGL renderer isn't hot swappable #85970

Tyriar opened this issue Dec 2, 2019 · 2 comments · Fixed by #106203
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-rendering verified Verification succeeded
Milestone
September 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 2, 2019

No description provided.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label labels Dec 2, 2019
@Tyriar Tyriar added this to the Backlog milestone Dec 2, 2019
@Tyriar Tyriar self-assigned this Dec 2, 2019
This was referenced Dec 2, 2019
Closed
Closed
@Tyriar Tyriar modified the milestones: Backlog, September 2020 Sep 7, 2020
Tyriar added a commit that referenced this issue Sep 7, 2020
@Tyriar
Support hot swap on webgl renderer
fee2d36 
Fixes #85970
@Tyriar Tyriar mentioned this issue Sep 7, 2020
Merged
@JacksonKearl JacksonKearl added the verification-steps-needed Steps to verify are needed for verification label Oct 1, 2020
@JacksonKearl
Copy link
Contributor

Not sure how to tell if the swap was made.

One issue is that the descriptions still says hot swap isn't supported.

@JacksonKearl JacksonKearl mentioned this issue Oct 1, 2020
Closed
@JacksonKearl
Copy link
Contributor

Verified by timing tree against vscode... canvas is 7.5-8s webgl is 5.5-6. Opened #107858 to track description mismatch

@JacksonKearl JacksonKearl added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Oct 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-rendering verified Verification succeeded
Projects
None yet
Milestone
September 2020
Development

Successfully merging a pull request may close this issue.

Hot swap support and force redraw on resume with webgl renderer microsoft/vscode
3 participants
@Tyriar @JacksonKearl and others