Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings editor accessibility #104286

Closed
wants to merge 10 commits into from

Conversation

9at8
Copy link
Member

@9at8 9at8 commented Aug 8, 2020

#97567

This PR includes a number of improvements in the settings editor.

Settings is made up of smaller virtual lists for each category

Each group only renders its own settings, and scrolling the settings list doesn't cross into a different group. The current settings editor is just one giant list of all settings. This change makes the settings page easier to navigate, and also make it less intimidating.

Before After
before after

Settings are navigable using arrow keys instead of tab keys

This change makes navigating the settings editor experience closer to what it's like for lists and trees in other parts of VSCode. Before, the setting page behaved like a form. That is, users had to tab through each control on the page to navigate to a setting. Now, users can tab to the settings list once and then use arrow keys to jump from one setting to the next. To edit that setting, they can press the tab key to go into the settings control.

Before After
before after

TOC tree can be focused by pressing Escape while navigating the settings list

Before, there was no easy way to focus on the table of contents on the left. Now, users can press the Escape key while focused on a setting to jump to the table of contents. Pressing escape again shifts focus back to the search box!

Before After
before after

@9at8
Copy link
Member Author

9at8 commented Aug 8, 2020

cc: @roblourens

@roblourens roblourens closed this Aug 31, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants