Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated "Code - OSS" icon for macOS Big Sur #124416

Merged
merged 22 commits into from
Jun 16, 2021
Merged

Updated "Code - OSS" icon for macOS Big Sur #124416

merged 22 commits into from
Jun 16, 2021

Conversation

LcJuves
Copy link
Contributor

@LcJuves LcJuves commented May 22, 2021

This PR fixes visual inconsistency under macOS Big Sur

Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR! It would be great if we could get the OSS shape and shadows to match our regular ones:

image

Let me know if you need a Figma file and I can share ours

@LcJuves
Copy link
Contributor Author

LcJuves commented May 25, 2021

However, my icon design template was downloaded from Apple’s official website, and there should not be any uneven shape and shadows.

The corresponding website and design resource links are as follows:

Oh, what's wrong~
Finally, I still hope you can share the Figma file, let us design a better Code - OSS icon for macOS Big Sur.

@miguelsolorio
Copy link
Contributor

We'd prefer to have all of our icons match, here's a sample of our Figma template that we used. I dropped a sample icon that you can replace.

image

@LcJuves
Copy link
Contributor Author

LcJuves commented May 29, 2021

Okay, here is the final design draft.
The SVG of the center icon is here.

The final effect is as follows:

image

@LcJuves LcJuves requested a review from miguelsolorio May 29, 2021 16:05
@miguelsolorio miguelsolorio added this to the June 2021 milestone Jun 1, 2021
@miguelsolorio
Copy link
Contributor

Since we're already in endgame for this release I'm marking this for June

@LcJuves
Copy link
Contributor Author

LcJuves commented Jun 2, 2021

Okay, I have merged the behind commits

@miguelsolorio
Copy link
Contributor

@LiangchengJ reviewing this again and I'm seeing the drop shadow come through the middle of the shape, which isn't pretty. Do you mind updating it to fix that? my original sample has an example of this

image

@LcJuves
Copy link
Contributor Author

LcJuves commented Jun 12, 2021

Okay, no problem~
Let's see how this one:
Figma

image

@misolori

Copy link
Contributor

@miguelsolorio miguelsolorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this looks good to me!

@miguelsolorio miguelsolorio enabled auto-merge June 16, 2021 05:49
@miguelsolorio miguelsolorio merged commit 5cfa24e into microsoft:main Jun 16, 2021
@microsoft microsoft deleted a comment from aiwinn Jun 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants