Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to not show link hovers for terminal #124926

Merged
merged 2 commits into from
Jun 7, 2021
Merged

add option to not show link hovers for terminal #124926

merged 2 commits into from
Jun 7, 2021

Conversation

nrayburn-tech
Copy link
Contributor

@nrayburn-tech nrayburn-tech commented May 30, 2021

Adds an option to disable showing link hovers in the terminal.

Testing

  1. Open a terminal and having a link inside of it. (echo "http://localhost:3000").
  2. Hover the link and see that a hover displays.
  3. Modify the setting terminal.integrated.showLinkHover to be false.
  4. Hover the link again and see that a hover does not display.

This PR fixes #113913 (comment), but not the entire issue of hovers not disappearing.

Fixes #125282

@Tyriar
Copy link
Member

Tyriar commented Jun 2, 2021

Created #125282 for this so it gets verified

@meganrogge
Copy link
Contributor

Looks good, thank you for contributing 👍🏼

@meganrogge meganrogge merged commit 1a41c51 into microsoft:main Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create setting to disable terminal hovers Terminal hover labels don't go away
4 participants