-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide simpler route for activating shell integration #155046
Conversation
Another approach would be to output the whole script when calling such command instead of script path. Like Homebrew's shellenv: eval "$(brew shellenv)" Or other tools which generates completion scripts, like:
|
@felipecrs I think since we'll say to use the if term_program is vscode, the eval should work the same as sourcing the file As for completions, shell integration doesn't need completions to work, but we have some early prototypes for how to tackle that problem starting with pwsh #154662 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test but lgtm
Provide simpler route for activating shell integration
Provide simpler route for activating shell integration
Fixes #153921