Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt ext host restart for custom editors #182558

Merged
merged 4 commits into from
May 18, 2023
Merged

Adopt ext host restart for custom editors #182558

merged 4 commits into from
May 18, 2023

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented May 15, 2023

For #180514

@mjbvz mjbvz added this to the May 2023 milestone May 15, 2023
@mjbvz mjbvz requested a review from bpasero May 15, 2023 21:04
@mjbvz mjbvz self-assigned this May 15, 2023
bpasero
bpasero requested changes May 17, 2023
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz I think its better the extension service to inform the user about the veto, like this:

image

I have this in the works in #182718. To adopt, when you veto you also pass in a reason.

@mjbvz mjbvz enabled auto-merge (squash) May 17, 2023 19:55
@mjbvz mjbvz merged commit 1c95491 into microsoft:main May 18, 2023
@bpasero bpasero mentioned this pull request May 25, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@mjbvz @bpasero