Support terminal shell args as string #22565

Tyriar · 2017-03-13T22:45:16Z

Fixes #19078

Tyriar · 2017-03-14T18:22:28Z

src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts

@@ -391,7 +391,7 @@ export class TerminalTaskSystem extends EventEmitter implements ITaskSystem {
 			} else {
 				(this.terminalService.configHelper as TerminalConfigHelper).mergeDefaultShellPathAndArgs(shellLaunchConfig);
 			}
-			let shellArgs = shellLaunchConfig.args.slice(0);
+			let shellArgs = <string[]>shellLaunchConfig.args.slice(0);


@weinand FYI IShellLaunchConfig can now have args as a string to support @dbaeumer's use case of needed to use a pre-escaped set of arguments. I needed to make this change which I believe shouldn't cause any issues.

Support terminal shell args as string

cbe0024

Fixes #19078

Tyriar added this to the March 2017 milestone Mar 13, 2017

Tyriar self-assigned this Mar 13, 2017

msftclas added the cla-already-signed label Mar 13, 2017

Clarify comment

ca7e200

Tyriar commented Mar 14, 2017

View reviewed changes

Tyriar merged commit 5cbb1b0 into master Mar 14, 2017

Tyriar deleted the tyriar/19078 branch March 14, 2017 18:22

github-actions bot locked and limited conversation to collaborators Mar 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support terminal shell args as string #22565

Support terminal shell args as string #22565

Tyriar commented Mar 13, 2017

Tyriar Mar 14, 2017

Support terminal shell args as string #22565

Support terminal shell args as string #22565

Conversation

Tyriar commented Mar 13, 2017

Tyriar Mar 14, 2017

Choose a reason for hiding this comment