chat: code pill polishes #241133
Merged
chat: code pill polishes #241133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now keep a 'postEdit' snapshot so we can make sure we're always able to show diffs, fixing the issue with the last pill and some other state bugs. I think this fixes microsoft/vscode-copilot#13229 - Made the observable for `getEntryDiffBetweenStops` proper and react to various updates. Made its type independent of the IDocumentDiff @jrieken - Clicking on a pill now opens the change made at that point in time.
meganrogge
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
able to show diffs, fixing the issue with the last pill and some
other state bugs. I think this fixes https://github.com/microsoft/vscode-copilot/issues/13229
getEntryDiffBetweenStopsproper and react tovarious updates. Made its type independent of the IDocumentDiff @jrieken