Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make upstream fig specs folder readonly #242798

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make upstream fig specs folder readonly #242798

wants to merge 4 commits into from
+6,070 −6,166

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 6, 2025 •
edited
Loading

Summary:

  • Move all modifications to get to compile into the update-specs.js script
  • Make the upstream/ folder readonly
  • Fork the npx spec since we don't want to special case certain CLIs as in upstream

Fixes #242795

@Tyriar Tyriar added this to the March 2025 milestone Mar 6, 2025
@Tyriar Tyriar requested a review from meganrogge March 6, 2025 12:35
@Tyriar Tyriar self-assigned this Mar 6, 2025
@Tyriar Tyriar enabled auto-merge March 6, 2025 12:35
@Tyriar
Copy link
Member Author

Tyriar commented Mar 6, 2025

Fixes for most of the upstream edits coming:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganrogge meganrogge Awaiting requested review from meganrogge

At least 1 approving review is required to merge this pull request.

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
March 2025
Development

Successfully merging this pull request may close these issues.

Improve flow for updating fig specs from upstream
1 participant
@Tyriar