Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file dialog service to fix layer breaker #81171

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Refactor file dialog service to fix layer breaker #81171

merged 6 commits into from
Sep 23, 2019

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Sep 19, 2019

Fixes #81161

@alexr00 alexr00 self-assigned this Sep 19, 2019
@alexr00
Copy link
Member Author

alexr00 commented Sep 19, 2019

@aeschli I think you are the person who owns the file dialog service the most. This is a very simple refactor (only moving code, not other changes) to fix a layer breaker exposed by Ben's electron service changes. Do you want to review this before I merge?

@bpasero bpasero self-requested a review September 20, 2019 05:26
@bpasero bpasero added this to the September 2019 milestone Sep 20, 2019
@aeschli aeschli self-requested a review September 20, 2019 09:08
@alexr00 alexr00 merged commit a5ea66d into master Sep 23, 2019
@alexr00 alexr00 deleted the alexr00/refactorFileDialog branch September 23, 2019 08:29
@anthonydresser anthonydresser mentioned this pull request Sep 25, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@alexr00 alexr00

Labels
None yet
Projects
None yet
Milestone
September 2019
Development

Successfully merging this pull request may close these issues.

File dialog service breaks layers
3 participants
@alexr00 @bpasero @aeschli