std and alloc improvements
#1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MarijnS95
reviewed
Nov 12, 2021
| impl ::core::convert::From<&str> for BSTR { | ||
| fn from(value: &str) -> Self { | ||
| let value: ::std::vec::Vec<u16> = value.encode_utf16().collect(); | ||
| let value: ::windows::runtime::alloc::vec::Vec<u16> = value.encode_utf16().collect(); |
There was a problem hiding this comment.
@kennykerr Shouldn't this and other allocations for BSTR be wrapped in the alloc feature just like some of the other functions?
In other words, perhaps you should hide:
#[doc(hidden)]
pub extern crate alloc;Behind the alloc feature too?
There was a problem hiding this comment.
The alloc feature is to avoid implicit allocations like IntoParam. From/Into should still work regardless as they are explicit.
This was referenced Nov 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_stdno longer removes all of the string conversion operations.allocfeature was added to enable implicit parameter allocations for strings.