Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tool_yml and extend Clippy coverage #3516

Merged
merged 5 commits into from
Feb 25, 2025
Merged

Simplify tool_yml and extend Clippy coverage #3516

merged 5 commits into from
Feb 25, 2025

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Feb 25, 2025

Building on #3504 this update further refactors tool_yml to make it easier to author by splitting each yml file generation into a separate module. Some minor tweaks to yml generation are also included:

  • Clippy now checks everything except the test crates since they're too noisy and have intentional test code that Clippy doesn't like. Automate yml workflow generation for MSRV checks #3504 reduced clippy coverage to just libs but I realized that some tools and samples can benefit from Clippy validaiton.
  • The clippy and no-default-features yml workflows are simplified by removing the unnecessary strategy matrix since those only run on nightly-x86_64-pc-windows-msvc.

@kennykerr kennykerr changed the title yml2 Simplify tool_yml and improve Clippy coverage Feb 25, 2025
@kennykerr kennykerr changed the title Simplify tool_yml and improve Clippy coverage Simplify tool_yml and extend Clippy coverage Feb 25, 2025
@kennykerr
Copy link
Collaborator Author

Removed the samples from clippy coverage for now as they're running into some build dependency issues.

@kennykerr kennykerr merged commit 299d421 into master Feb 25, 2025
34 checks passed
@kennykerr kennykerr deleted the yml2 branch February 25, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant