Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster cores not set when more cores than available are requested #2

Closed
mihaiconstantin opened this issue Apr 29, 2022 · 0 comments · Fixed by #12
Closed

Cluster cores not set when more cores than available are requested #2

mihaiconstantin opened this issue Apr 29, 2022 · 0 comments · Fixed by #12
Assignees
Labels
bug Something isn't working

Comments

@mihaiconstantin
Copy link
Owner

mihaiconstantin commented Apr 29, 2022

Somewhere on the else if branch (i.e., see below) we need to set the maximum number of cores that can be used, e.g.,:

# Set the cores.
private$.cores <- private$.allowed_cores

powerly/R/Backend.R

Lines 38 to 43 in d6be4e6

} else if (cores > private$.allowed_cores) {
# Warn the user.
warning(paste0("Argument `cores` cannot be larger than ", private$.allowed_cores, ". Setting to ", private$.allowed_cores, "."))
# Honor the user request without any constraints.
} else {

@mihaiconstantin mihaiconstantin added the bug Something isn't working label Apr 29, 2022
@mihaiconstantin mihaiconstantin self-assigned this Apr 29, 2022
@mihaiconstantin mihaiconstantin moved this from Backlog to Todo in powerly Apr 29, 2022
@mihaiconstantin mihaiconstantin removed the status in powerly Apr 29, 2022
@mihaiconstantin mihaiconstantin moved this to Todo in powerly Apr 29, 2022
@mihaiconstantin mihaiconstantin moved this from Todo to In Progress in powerly Apr 29, 2022
mihaiconstantin added a commit that referenced this issue Apr 29, 2022
Fix: limit cores when too many are requested (#2)
Repository owner moved this from In Progress to Done in powerly Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant