SARC-391 fix account matching & related sanity check #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX account matching error due to duplicate entries in drac_members CSV file
nurbal
changed the title
bouthilx
reviewed
Feb 21, 2025
| @@ -163,28 +163,29 @@ def test_acquire_users(cli_main, patch_return_values, mock_file, captrace): | |||
|
|
|||
| assert spans[1].name == "match_drac_to_mila_accounts" | |||
| assert spans[1].status.status_code == StatusCode.OK | |||
| assert len(spans[1].events) == 9 | |||
There was a problem hiding this comment.
Il faudrait ajouter un test qui vérifie le genre de problème corrigé dans cette PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix an old problem unnoticed since project start: the multiple entries for a given person in members_drac CSV file were not handled properly.
With this PR, if a user has several entries in the CSV, the following priority is applied:
The function
alerts.db_sanity_check.users_accounts.check_users_in_jobs(time_interval: Optional[timedelta] = timedelta(hours=24)) -> list[str]is added and can be used by the health monitor, for example. It returns the list of usernames not found in theusersdb collection, present in the jobs from the lasttime_interval.