Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: rename root identity #160

Merged
merged 1 commit into from
Oct 11, 2021
Merged

config: rename root identity #160

merged 1 commit into from
Oct 11, 2021

Conversation

aead
Copy link
Member

@aead aead commented Oct 11, 2021

This commit renames the root identity to
admin identity. Therefore, it changes
the config file structure:

Before:

root: ...

After:

admin:
  identity: ...

Further, this commit removes the --root CLI flag.
From now on, the admin identity has to be specified
in the config file - but it can be inferred from the
environment.

Signed-off-by: Andreas Auernhammer [email protected]

@aead aead requested a review from Alevsk October 11, 2021 14:34
@aead aead force-pushed the admin-config branch 2 times, most recently from cf4f92e to f30b634 Compare October 11, 2021 15:08
This commit renames the root identity to
admin identity. Therefore, it changes
the config file structure:

Before:
```yaml

root: ...
```

After:
```yaml

admin:
  identity: ...
```

Further, this commit removes the `--root` CLI flag.
From now on, the admin identity has to be specified
in the config file - but it can be inferred from the
environment.

Signed-off-by: Andreas Auernhammer <[email protected]>
@aead aead merged commit 6bdc0ff into master Oct 11, 2021
@aead aead deleted the admin-config branch October 11, 2021 20:49
@bboreham
Copy link

bboreham commented Nov 2, 2021

May I suggest updating the instructions at https://github.com/minio/kes/wiki/Getting-Started which don't work since --root has been removed.

@harshavardhana
Copy link
Member

May I suggest updating the instructions at https://github.com/minio/kes/wiki/Getting-Started which don't work since --root has been removed.

@aead isn't this is expected to be backward compatible?

@aead
Copy link
Member Author

aead commented Nov 4, 2021

@bboreham Thanks for the hint. We will update the guides accordingly. However, this change is not released yet. It is only removed in upstream/master In the future, we will expect a config file.

@harshavardhana We will drop the --root (and probably other flags) to simply the CLI. Maybe we will need new flags for the stateful cluster mode.

@bboreham
Copy link

bboreham commented Nov 4, 2021

It was released as part of https://github.com/minio/kes/releases/tag/v0.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants