Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge: fix recursion bug in iterator #350

Merged
merged 1 commit into from
Apr 18, 2023
Merged

edge: fix recursion bug in iterator #350

merged 1 commit into from
Apr 18, 2023

Conversation

aead
Copy link
Member

@aead aead commented Apr 18, 2023

This commit fixes a recursion bug in the iterator
implementation.

This commit fixes a recursion bug in the iterator
implementation.

Signed-off-by: Andreas Auernhammer <[email protected]>
@aead aead requested a review from vadmeste April 18, 2023 10:56
Copy link
Contributor

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klauspost
Copy link
Contributor

@aead May I recommend adding staticcheck to CI?

It catches these:

test.go:12:9: infinite recursive call (SA5007)

@aead
Copy link
Member Author

aead commented Apr 18, 2023

@klauspost Will add that in a separate PR - which probably will fix a series of hints 👍

@aead aead merged commit 1e2225b into master Apr 18, 2023
@aead aead deleted the edge-close-iter branch April 18, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants