Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove package kms and keserv #359

Merged
merged 1 commit into from
May 10, 2023
Merged

remove package kms and keserv #359

merged 1 commit into from
May 10, 2023

Conversation

aead
Copy link
Member

@aead aead commented May 8, 2023

This commit removes the two packages kms and
keserv. Both packages are no longer needed since better implementations are available via the kv
and edge package.

This cleans up a some code and removes two layers
of indirection.

@aead aead requested review from Praveenrajmani and shtripat May 8, 2023 14:28
@aead aead force-pushed the remove-pkg-kms branch from f37fe50 to 749c090 Compare May 8, 2023 14:29
@aead
Copy link
Member Author

aead commented May 8, 2023

Requires #360

@aead aead force-pushed the remove-pkg-kms branch from 749c090 to d5cc5a8 Compare May 8, 2023 15:42
This commit removes the two packages `kms` and
`keserv`. Both packages are no longer needed since
better implementations are available via the `kv`
and `edge` package.

This cleans up a some code and removes two layers
of indirection.

Signed-off-by: Andreas Auernhammer <[email protected]>
@aead aead force-pushed the remove-pkg-kms branch from d5cc5a8 to 4d2b35d Compare May 8, 2023 16:07
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will try to do a sanity as well.

@aead aead merged commit 15e9a43 into master May 10, 2023
@aead aead deleted the remove-pkg-kms branch May 10, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants