Added unit tests for various key stores #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
requested changes
May 11, 2023
There was a problem hiding this comment.
Currently your tests are order dependent. We have to be able to run each test separately. Like go test -v -fs.path=<path> -run="FS_Create"
Maybe combine all FS tests into:
func TestFS(t *testing.T) {
config := edge.FSKeyStore{
Path: "./keys",
}
// Init the store - like create keys that should be there etc.
t.Run("create", ...)
t.Run("delete", ...)
// Add more tests
}
shtripat
changed the title
shtripat
force-pushed
the
edge-tests
branch
6 times, most recently
from
c75504b to
b621ad6
Compare
aead
requested changes
May 15, 2023
|
Also, can you squash the commits into one and add a commit message explaining the purpose of this change and why things are done in a certain way - e.g. why we use the config file CLI flag approach etc. @shtripat |
Sure. Will do that. |
aead
approved these changes
May 15, 2023
Purpose of this change is to enable testing of various backend key stores like Azure, GCP, HashiCorp Vault etc. The tests use command like flags e.g. `aws.config`, `azure.config` to get details to connect to the key store. This is done to make the changes generic and so code remains agnostic to addition of new keystores. Also this way we are making sure all backend key store integrations work just fine and later when integrated with KES server and client making calls through KES server, there wont be ny surprises. Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this change is to enable testing of various backend key stores like Azure, GCP, HashiCorp Vault etc. The tests use command like flags e.g.
aws.config,azure.configto get details to connect to the key store. This is done to make the changes generic and so code remains agnostic to addition of new keystores.Also this way we are making sure all backend key store integrations work just fine and later when integrated with KES server and client making calls throughKES server, there wont be any surprises.