Refactored kestest integration tests
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
force-pushed
the
refactor-kestest
branch
from
e24921d to
3ff71e0
Compare
aead
requested changes
May 17, 2023
There was a problem hiding this comment.
Minor tweaks. Also consider a descriptive commit message as suggested by the contributing doc.
Ref: https://github.com/minio/kes/blob/master/CONTRIBUTING.md#commit-message
kestest/gateway_test.go
Outdated
| @@ -633,3 +626,28 @@ func mustDecodeB64(s string) []byte { | |||
| } | |||
| return b | |||
| } | |||
|
|
|||
| func clean(ctx context.Context, client *kes.Client, pattern string, t *testing.T) { | |||
There was a problem hiding this comment.
You can omit the pattern here and use the match all pattern * in ListKeys.
There was a problem hiding this comment.
You can omit the pattern here and use the match all pattern
*inListKeys.
Ok, makes sense. Will do the changes.
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
refactor-kestest
branch
from
343ea85 to
2e4fa01
Compare
aead
requested changes
May 17, 2023
| defer iter.Close() | ||
|
|
||
| names := []string{} | ||
| keysInfo, err := iter.Values(-1) |
There was a problem hiding this comment.
iter.Values(-1) already collects all KeyInfo objects into one slice. You don't need to clone this slice again.
You can simply remove:
for _, keyInfo := range keysInfo {
names = append(names, keyInfo.Name)
}
An just do one for loop:
for _, info := range keyInfos {
if err = client.DeleteKey(ctx, info.Name); err != nil {
t.Errorf("Cleanup: failed to delete '%s': %v", name, err)
}
}
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
shtripat
force-pushed
the
refactor-kestest
branch
from
2e4fa01 to
6d6b57b
Compare
aead
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cleanup method to make sure each test works in its entirety and there are no left outs.
Also all tests use the same common functions for scenarios like
create,import,generate,encryptanddecryptetc.Different kind of tests can be executed using
go test -v -run="<test>"command.e.g.
go test -v -run="TestGatewayMem"orgo test -v -fs.path=./keys -run="TestGatewayFS"