edge: use random secret key names and delete at end of each test #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
force-pushed
the
random-key-names-in-tests
branch
from
c135ea3 to
56d6ce8
Compare
shtripat
changed the title
aead
force-pushed
the
random-key-names-in-tests
branch
from
8dc725a to
bd3f7da
Compare
harshavardhana
approved these changes
Jul 7, 2023
Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
There is already a defer iter.Close() so we dont need last one in function Signed-off-by: Shubhendu Ram Tripathi <[email protected]>
aead
force-pushed
the
random-key-names-in-tests
branch
from
bd3f7da to
ffb43cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use random secret key names in tests in the form
prefix-seed-counter. This way keys become randomized yet predictable tests.Also fixed an issue with vault test where type of store config was wrong.