Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio multipart upload throws an exception, but sdk donot catch and throws it #1594

Closed
goyjy opened this issue Nov 14, 2024 · 4 comments · Fixed by #1595
Closed

minio multipart upload throws an exception, but sdk donot catch and throws it #1594

goyjy opened this issue Nov 14, 2024 · 4 comments · Fixed by #1595

Comments

@goyjy
Copy link

goyjy commented Nov 14, 2024

【version】
minio version:RELEASE.2023-01-31T02-24-19Z
minio-java version:8.4.3

【description】
When I did a multipart upload, the multipart upload failed because the bucket's quota was exceeded, but the client did not catch the exception.

minio trace logs
image

reason for error is "Bucket quota exceeded"

Looking at the source code, we found that when the multipart upload fails, the abortMultipartUploadAsync method needs to be executed, so the multipart upload error will not be thrown.
image

【expectation】
Error message for multipart upload failure can be thrown

@balamurugana
Copy link
Member

What error does the server throw to the client? If the server sends success, nothing can be done at client side.

@klauspost
Copy link

@balamurugana Server sent 400 on PutObjectPart. This was caught by the client, which then called AbortMultipartUpload.

It seems like successfully aborting swallows the original issue, right?

@goyjy
Copy link
Author

goyjy commented Nov 14, 2024

What error does the server throw to the client? If the server sends success, nothing can be done at client side.

The process is like this:
1、Java sdk upload object parts;
2、The minio server returned error code 400 because "Bucket quota exceeded";
3、Java sdk catch the server-side error and executes the abortMultipartUploadAsync method;
4、The abortMultipartUploadAsync method executes successfully and returns,But the "Bucket quota exceeded" error is not thrown upward.

When I call java sdk to do multipart upload, java sdk returns success. But in fact the object was not uploaded successfully

@balamurugana
Copy link
Member

Actually you are not getting exception in this case, but getting null response. Will send a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants