Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close scanner always including when exception occurred #537

Merged
merged 1 commit into from
Mar 11, 2017
Merged

fix: close scanner always including when exception occurred #537

merged 1 commit into from
Mar 11, 2017

Conversation

harshavardhana
Copy link
Member

No description provided.

balamurugana
balamurugana approved these changes Mar 11, 2017
View reviewed changes
Copy link
Member

@balamurugana balamurugana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add commit log like

fix: close scanner always including when exception occurred

@harshavardhana harshavardhana changed the title Move scanner.close() as part of try{}finally{} block fix: close scanner always including when exception occurred Mar 11, 2017
@harshavardhana
Copy link
Member Author

fix: close scanner always including when exception occurred

Done!

@harshavardhana harshavardhana merged commit 5abef3c into minio:master Mar 11, 2017
@harshavardhana harshavardhana deleted the scanner branch March 11, 2017 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balamurugana balamurugana balamurugana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshavardhana @balamurugana