Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle accelerate and dual-stack aws endpoints #900

Merged
merged 1 commit into from
May 22, 2020
Merged

handle accelerate and dual-stack aws endpoints #900

merged 1 commit into from
May 22, 2020

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Apr 13, 2020 •
edited
Loading

Fixes #893
Fixes #894
Fixes #895
Fixes #897
Fixes #899
Fixes #926

@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch 9 times, most recently from 4b01350 to a42417e Compare April 13, 2020 12:08
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch from a42417e to 1fff843 Compare April 14, 2020 14:08
BigUstad
BigUstad previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@BigUstad BigUstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana dismissed stale reviews from sinhaashish and BigUstad via ee90822 April 21, 2020 14:21
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch 2 times, most recently from ee90822 to b889b8e Compare April 21, 2020 15:10
@kannappanr
Copy link
Contributor

ping @BigUstad @sinhaashish

@balamurugana balamurugana mentioned this pull request Apr 27, 2020
Closed
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch 2 times, most recently from b2e971b to b84ca98 Compare May 2, 2020 04:49
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch from b84ca98 to c8cd33f Compare May 6, 2020 08:09
@balamurugana balamurugana mentioned this pull request May 10, 2020
Closed
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch 6 times, most recently from 82d3366 to 0770de1 Compare May 19, 2020 16:37
@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch from 0770de1 to 92862cf Compare May 19, 2020 16:49
sinhaashish
sinhaashish previously approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch from 92862cf to 4b71244 Compare May 21, 2020 08:35
anjalshireesh
anjalshireesh requested changes May 21, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Instead of having so many different constructors for MinioClient, We could use the builder pattern here also i.e. a single constructor that takes an instance of a new MinioClientConfig class, which
    can be built using the builder pattern.
  • Don't think the methods isValidEndpoint, checkBucketName, checkObjectName, normalizeHeaders, getHostHeader, getAvailableSize need to be made static

@balamurugana balamurugana force-pushed the handle-accelerate-and-dual-stack-aws-endpoints branch from 4b71244 to 341153b Compare May 21, 2020 13:13
@anjalshireesh anjalshireesh self-requested a review May 21, 2020 13:53
anjalshireesh
anjalshireesh approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@anjalshireesh anjalshireesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sinhaashish
sinhaashish approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@sinhaashish sinhaashish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 9f74b73 into minio:master May 22, 2020
@balamurugana balamurugana deleted the handle-accelerate-and-dual-stack-aws-endpoints branch May 22, 2020 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjalshireesh anjalshireesh anjalshireesh approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@BigUstad BigUstad BigUstad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@balamurugana @kannappanr @anjalshireesh @sinhaashish @BigUstad