-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle accelerate and dual-stack aws endpoints #900
handle accelerate and dual-stack aws endpoints #900
Conversation
4b01350
to
a42417e
Compare
a42417e
to
1fff843
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ee90822
to
b889b8e
Compare
ping @BigUstad @sinhaashish |
b2e971b
to
b84ca98
Compare
b84ca98
to
c8cd33f
Compare
82d3366
to
0770de1
Compare
0770de1
to
92862cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
92862cf
to
4b71244
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Instead of having so many different constructors for
MinioClient
, We could use the builder pattern here also i.e. a single constructor that takes an instance of a newMinioClientConfig
class, which
can be built using the builder pattern. - Don't think the methods
isValidEndpoint, checkBucketName, checkObjectName, normalizeHeaders, getHostHeader, getAvailableSize
need to be madestatic
4b71244
to
341153b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #893
Fixes #894
Fixes #895
Fixes #897
Fixes #899
Fixes #926