-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed thread and mutex_m dependencies #973
Conversation
lib/minitest.rb
Outdated
def mutex # :nodoc: | ||
@mutex | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def mutex # :nodoc: | |
@mutex | |
end | |
def synchronize(&block) # :nodoc: | |
@mutex.synchronize(&block) | |
end |
This would be cleaner interface-wise and avoid exposing the Mutex.
Also it would avoid needing changes in lib/minitest/parallel.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks. It's better than my changes.
DONE! Thank you. Sorry for the delay. I'll get this out in the next release shortly |
@zenspider Thank you! |
@zenspider hope you don't mind the ping. When do you except to cut the next release? Ruby main has now removed mutex_m code and as such testing against ruby-head errors unless manually adding it to the gemfile/gemspec. |
Just released v5.21.0 with this fix. |
Thank you, I appreciate that very much. |
Thanks always! |
Ruby core team have plan to extract
mutex_m
from stdlib at Ruby 3.4. After that,minitest
needs to dependmutex_m
gem.I replaced
mutex_m
with simpleMutex
usage. But I'm not familiar with thread programming. It may be wrong usage.