Unix: don't leak FDs if Network.connect fails
#206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use `Lwt` to open connections so we don't block the whole process.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jul 17, 2020
…rpc and capnp-rpc-net (0.8.0) CHANGES: Bug fixes and diagnostics: - Don't GC imports with callbacks (@talex5, mirage/capnp-rpc#210). - Improve "Already resolved!" error message (@talex5, mirage/capnp-rpc#209). Show the state of the promise we were trying to set, and what we tried to set it to. - Reject attempts to send after disconnecting (@talex5, mirage/capnp-rpc#208). - Unix: don't leak FDs if `Network.connect` fails (@talex5, mirage/capnp-rpc#206). Also, use `Lwt` to open connections so we don't block the whole process. New functions: - Add `Sturdy_ref.with_cap` and `with_cap_exn` convenience functions (@talex5, mirage/capnp-rpc#207). Using the plain `connect` functions, it's easy to forget to release the live-ref at the end. Build changes: - capnp-rpc-mirage: adapt test to tcpip 5.0.0 API (@hannesm, mirage/capnp-rpc#205). - Upgrade to dune 2 (@talex5, mirage/capnp-rpc#204). - Switch tests to build in native code and use the test stanza (@avsm, mirage/capnp-rpc#203). Documentation: - Show how to make a connection directly (@talex5, mirage/capnp-rpc#202). The new `test-bin/calc_direct.ml` example shows how a parent process can spawn a child and communicate with it directly over a socketpair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use
Lwtto open connections so we don't block the whole process.