Use open_in_bin instead of open_in for Windows compatibility

[MisterDA]

No description provided.

[MisterDA]

The problem is with the snippet:

let read_whole_file path =
    let ch = open_in path in
    let len = in_channel_length ch in
    let s = really_input_string ch len in
    close_in ch;
    s

So on Windows with crlf line endings, open_in (text mode) does the
conversion but in_channel_length does not and counts two characters
per line, as in binary mode; but really_input_string is in text mode
and sees only one character per endline. So in the end it will have
seen less characters than expected (the len argument) and raise
End_of_file.

For the URL change, (edit: without the patch) I fixed it by using
dos2unix on the file (that’s where I encountered the exception). For
the other change, I’ve not had any problem but my understanding is
that you’re serializing something and my gut instinct tells me to open
the file in binary mode :)

I’ve also seen code such as below, and I’m wondering if it’ll cause
problems later; I’ll find a way to check that.

let outfile path data =
  let ch = open_out path in (* but was it text mode or bin? *)
  let data = data ^ "\n" in (* check the endline style accordingly *)
  output_string ch data;
  close_out ch

[talex5]

Ah, I see! I've pushed some more commits to use binary mode for saving too, and to fix the compiler warning on 4.12.