Replace wait_until_settled with safer await_settled
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wait_until_settled` makes it too easy to ignore errors.
talex5
added a commit
to talex5/ocluster
that referenced
this pull request
Jun 4, 2021
We waited until the connection attempt resolved, but didn't check that
it was successful. We then misleadingly printed "Waiting for worker"
before noticing that the connection had failed and retrying it.
Connecting to build cluster...
Waiting for worker...
Connecting to build cluster...
Waiting for worker...
...
Now we detect the problem immediately, log the error, and retry after a
delay without spamming the job logs.
I've also made a PR against capnp-rpc to avoid mistakes like this in
future: mirage/capnp-rpc#233
Reported by Antonin Décimo.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jun 10, 2021
…nix and capnp-rpc-lwt (1.2) CHANGES: - Don't crash if the peer disconnects before the bootstrap reply is ready (@talex5 mirage/capnp-rpc#234). When replying to a normal question we checked that the answer was still needed before trying to reply, but didn't for bootstrap requests. - Replace `wait_until_settled` with safer `await_settled` (@talex5 mirage/capnp-rpc#233). `wait_until_settled` makes it too easy to ignore errors. - Require fmt >= 0.8.7 for `kstr` and set OCaml 4.08 as the minimum version everywhere (@talex5 mirage/capnp-rpc#232). Older versions aren't tested in CI because the unix and mirage packages require at least OCaml 4.08.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jun 10, 2021
…nix and capnp-rpc-lwt (1.2) CHANGES: - Don't crash if the peer disconnects before the bootstrap reply is ready (@talex5 mirage/capnp-rpc#234). When replying to a normal question we checked that the answer was still needed before trying to reply, but didn't for bootstrap requests. - Replace `wait_until_settled` with safer `await_settled` (@talex5 mirage/capnp-rpc#233). `wait_until_settled` makes it too easy to ignore errors. - Require fmt >= 0.8.7 for `kstr` and set OCaml 4.08 as the minimum version everywhere (@talex5 mirage/capnp-rpc#232). Older versions aren't tested in CI because the unix and mirage packages require at least OCaml 4.08.
talex5
added a commit
to talex5/capnp-rpc
that referenced
this pull request
Jul 12, 2022
When a vat is shut down it ends all registered connections and stops accepting new ones. However, if a connection was in progress (e.g. doing the TLS handshake but not yet registered) then we would miss it. The `test_parallel_fails` test got upgraded to the stricter `await_settled_exn` in mirage#233, which was wrong but that wasn't detected due to this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_until_settledmakes it too easy to ignore errors.