Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capnp-rpc-lwt.opam #262

Closed
wants to merge 3 commits into from
Closed

Conversation

tmcgilchrist
Copy link
Member

Testing the lower-bounds check for ocaml-ci

Copy link
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Why is it a draft?

Would be interesting to know why the Windows build is failing, but looks unrelated to this PR:

  the following programs are not installed properly:
   curl
  I can't proceed :(

@tmcgilchrist tmcgilchrist marked this pull request as ready for review February 19, 2023 21:24
@tmcgilchrist
Copy link
Member Author

@talex5 issue with setup-ocaml on Windows ocaml/setup-ocaml#645.

@tmcgilchrist
Copy link
Member Author

This has a bug with the chosen lower bounds, the tests timeout. It is not clear whether it is caused by alcotest or dune. I am still debugging it by choosing newer versions of dependencies until it passes.

@talex5
Copy link
Contributor

talex5 commented Feb 23, 2023

With a bit of testing locally, I see:

  capnp-rpc [WARNING] -----       : Uncaught async exception in "Message sender thread": (Invalid_argument Uint32.of_int)

@talex5
Copy link
Contributor

talex5 commented Feb 23, 2023

This seems bad:

utop # #require "stdint";;
utop # let max_val = Stdint.Uint32.to_int (Stdint.Uint32.max_int);;
val max_val : int = -1

It seems to have been fixed by andrenth/ocaml-stdint@5e750d7 ("Migrate from jbuilder to dune"), which seems odd. Debugging it would require messing around with jbuilder, so probably capnproto just needs a lower-bound on stdint.

@talex5
Copy link
Contributor

talex5 commented Feb 23, 2023

Thanks - I included your fixes in #266.

@talex5 talex5 closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants