Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook testbed #11264

Closed
wants to merge 13 commits into from
Closed

Fix storybook testbed #11264

wants to merge 13 commits into from

Conversation

saschanaz
Copy link
Member

ローカルでpnpm --filter frontend build-storybookstorybook-devも動かないのでここでテスト

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/backend:test labels Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.75%. Comparing base (b6a432f) to head (5d4ab60).
Report is 2718 commits behind head on develop.

Files with missing lines Patch % Lines
...kend/src/server/api/endpoints/admin/update-meta.ts 60.00% 2 Missing ⚠️
packages/backend/src/server/api/endpoints/meta.ts 66.66% 2 Missing ⚠️
...kend/src/core/activitypub/models/ApImageService.ts 85.71% 1 Missing ⚠️
...ges/backend/src/server/api/endpoints/admin/meta.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11264      +/-   ##
===========================================
+ Coverage    77.68%   77.75%   +0.06%     
===========================================
  Files          910      908       -2     
  Lines        92033    91893     -140     
  Branches      7670     7703      +33     
===========================================
- Hits         71500    71455      -45     
+ Misses       20533    20438      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saschanaz
Copy link
Member Author

#11267

もうわからない

@Sayamame-beans
Copy link
Member

triage: 元となるissueが解決されていそうなのでcloseします 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Development

Successfully merging this pull request may close these issues.

2 participants