絵文字のオートコンプリート強化の対応 #12365
Merged
絵文字のオートコンプリート強化の対応 #12365
+78
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12365 +/- ##
===========================================
- Coverage 78.77% 78.77% -0.01%
===========================================
Files 947 947
Lines 102778 102778
Branches 8285 8284 -1
===========================================
- Hits 80968 80966 -2
- Misses 21810 21812 +2 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら |
syuilo
reviewed
Nov 22, 2023
| const queryChars = [...query]; | ||
| const hitEmojis = new Map<string, EmojiScore>(); | ||
|
|
||
| emojiDb.forEach(x => { |
There was a problem hiding this comment.
全く無いですね…コピペもとがsomeで、それをforEachにしただけでした
特にこだわりはない＋周りを見たらfor ofだったので合わせました
|
👍👍👍 |
5 tasks
anatawa12
pushed a commit
to anatawa12/misskey
that referenced
this pull request
Nov 26, 2023
* 前方一致・部分一致でなくても近似値でヒットするように * fix CHANGELOG.md * for of に変更 --------- Co-authored-by: osamu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
#12364 の対応です。
この対応により、絵文字をオートコンプリートが強化されます。
Why
絵文字名が長い時など、オートコンプリートの絞り込み機能が弱いと入力が面倒なため
Additional info (optional)
実際に動作させて確認
Checklist