-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: word mute did not apply to quote notes #12468
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12468 +/- ##
===========================================
- Coverage 79.67% 78.90% -0.77%
===========================================
Files 959 775 -184
Lines 108407 80156 -28251
Branches 8348 7840 -508
===========================================
- Hits 86372 63248 -23124
+ Misses 22035 16908 -5127 ☔ View full report in Codecov by Sentry. |
#12376 で違う形で(引用ごとsoft muteされる)効くようにした記憶があります |
It's slightly different. The purpose of this commit is to ensure that the behavior of quote and reply is the same. |
@syuilo 以下があったとして、
ノートBの中に表示されているノートAには、ワードミュートによる非表示機能が無いのでそれを追加しようという意図のようです。 |
LGTM |
@qwreey |
a2d3299
to
4dc5774
Compare
@samunohito Source code rebased. now, have no conflict! (I moved all commit to forward, for making git log clear) |
What
Apply word mute on quoted note like replied note to ensure consistency
Why
Unlike replied note, word mute is not affect on quoted note

Additional info (optional)
Checklist