Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI: Validate AppStream metadata #4317

Merged
merged 2 commits into from
Sep 21, 2021
Merged

GitHub CI: Validate AppStream metadata #4317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97484d6
GitHub CI: Validate AppStream metadata
uklotzde Sep 20, 2021
f26febd
GitHub CI: Update pre-commit/action
uklotzde Sep 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends clang-format-10

- name: "Detect code style issues (push)"
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].3
if: github.event_name == 'push'
# There are too many files in the repo that have formatting issues. We'll
# disable these checks for now when pushing directly (but still run these
Expand All @@ -30,7 +30,7 @@ jobs:
SKIP: end-of-file-fixer,trailing-whitespace,clang-format,eslint,no-commit-to-branch

- name: "Detect code style issues (pull_request)"
uses: pre-commit/[email protected].0
uses: pre-commit/[email protected].3
if: github.event_name == 'pull_request'
env:
SKIP: no-commit-to-branch
Expand All @@ -53,3 +53,10 @@ jobs:
with:
name: ${{ env.UPLOAD_PATCH_FILE }}
path: ${{ env.UPLOAD_PATCH_FILE }}

- name: "Install appstreamcli"
run: sudo apt-get update && sudo apt-get install -y --no-install-recommends appstream

# AppStream metadata has been generated/updated by a pre-commit hook
- name: "Validate AppStream metadata"
run: appstreamcli validate res/linux/org.mixxx.Mixxx.metainfo.xml