Auto DJ skip fix lp1941989 #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare conditions, we receive a stray position update which leads to a repeated loadNextTrackFromQueue() call, discarding the track currently loading. This effectively skips a track. Fixing lp:941989
uklotzde
suggested changes
Sep 21, 2021
| TrackPointer pLoadTrack; | ||
| { // locking scope | ||
| QMutexLocker locker(&m_newTrackMutex); | ||
| pLoadTrack = m_pNewTrack; | ||
| m_pNewTrack.reset(); | ||
| m_newTrackAvailable = false; | ||
| m_newTrackAvailable = 0; |
There was a problem hiding this comment.
m_newTrackAvailable.storeRelease(0)
|
Probably related? https://bugs.launchpad.net/mixxx/+bug/1859374 |
uklotzde
reviewed
Sep 22, 2021
uklotzde
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Thanks for stepping in! Let's see if the AutoDJ bug is fixed.
The interaction between CachingReader and the Engine is still complicated and hard to reason about. I expect that the code contains more race conditions and multi-threading bugs. Hopefully we don't wake some one of those hidden dragons by applying these changes ;) Eventually the code has to be rewritten. In Rust.
LGTM
|
I will merge to main. |
|
Seems like this or #4267 also fixed the Repeat Playlist issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix https://bugs.launchpad.net/mixxx/+bug/1941989 where tracks are skipped in AutoDJ.
This is hard to test, because skipping happens only under rare conditions. I was able to reproduce it unreliable with the "Full Track Mode" and a slow spinning USB HDD. With this PR I cannot reproduce it anymore.
The fix is implemented in two places: