-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version-tagged moonraker (v0.8.0
) is out of date
#111
Comments
Version-tagged moonraker images are out of date and have started to have issues with Mainsail. Reported upstream: mkuf/prind#111
Hey there, the build script is consuming tags from upstream and the most recent tag there is Easiest way to get a new tagged image would be to request a new tag from the moonraker maintainer. A little more complex (and probably intrusive) would be to add new versioning to prind images so that the tag contains an incrementing number since the last tagged release, to stay somewhat compliant w/ semver. From the top of my Head I'm thinking about something like Great work with kubeklipper 👍 -Markus |
Thanks for the quick response!
Ah, I completely missed that. I did not see any release in moonraker so I (mistakenly) think you were versioning them independently. I'll poke the moonraker maintainers to see if they are comfortable making a release 😄
Thank you! There are still a few rough edges here and there, and I haven't figured out a kubernetes-friendly way to flash klipper yet, but it's been working great for me for the last year. Feel free to drop me a line if you happen to try it! |
I modified the build script a little and could provide a new versioning scheme based on As the number of commits is increasing until a new tag is added, it should be possible to set a custom versioning scheme in renovate or any other tooling. Do you think this could work for you? About a kubernetes way to flash the mcu code. -Markus |
Thanks for taking the time to giving this a swing! I think the version-incremental-hash scheme should work great and might even work with renovate out of the box (as it is sortable) 🎉 re. the k8s way, I thought about having a job and some kind of barrier, but the more I think about it the more I believe that's operator logic somehow crammed into a chart. I think an operator will be a more maintainable way of doing the flashing thing, and could also unlock other cool features. I've drafted an issue here: nadiamoe/kubeklipper#17 For now, this is not a pressing thing to me, but if enough people show interest and/or volunteer that might happen some day :) |
Change in tagging has been implemented w/ #114. I'll cut out a new tagged release once all github actions have finished. |
v1.11.0 has been released. -Markus |
Hi there!
I'm a very happy user of your images, and I happen to rely on semver-tagged images as they are easier to upgrade in my ecosystem. I happened to realize, while updating my moonraker config, that the latest tagged image is still v0.8.0.
This version is starting to show incompatibility issues with Mainsail for example, where webcams stopped appearing in the dashboard (this was unpleasant to troubleshoot).
I've worked around this by using one of the commit-tagged images, but I'd really love if we could have a new tagged image for it.
Is there any blocker or reason why this hasn't happened? Can I help to make this happen somehow?
The text was updated successfully, but these errors were encountered: