Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add auth to project token endpoints #746

Merged
merged 11 commits into from
Jan 18, 2025
Merged

Conversation

inimaz
Copy link
Contributor

@inimaz inimaz commented Dec 14, 2024

Add authentication to the project-token endpoints.

FE changes:

  • remove use server from api tokens calls

BE changes

  • add authentication and authorization checks on the project-token endpoints
  • env variable CORS_ORIGIN
  • Now we run the api unit tests in every PR

@inimaz inimaz marked this pull request as draft December 18, 2024 12:33
@inimaz
Copy link
Contributor Author

inimaz commented Dec 18, 2024

Not mergeable yet, it needs changes in the frontend

@inimaz inimaz requested a review from prmths128 January 18, 2025 12:08
@inimaz inimaz marked this pull request as ready for review January 18, 2025 12:09
Copy link
Collaborator

@SaboniAmine SaboniAmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@inimaz inimaz merged commit 5385c50 into master Jan 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants