Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow accessing public project data #759

Merged
merged 1 commit into from
Jan 19, 2025
Merged

allow accessing public project data #759

merged 1 commit into from
Jan 19, 2025

Conversation

prmths128
Copy link
Contributor

@prmths128 prmths128 commented Jan 14, 2025 •
edited
Loading

Notes:

  • Added a new exception, refactored accordingly a few places. Can be extended to more files in another PR.
  • I changed a bit the message format to keep the variable part separate. Easier to search logs for the message.

@prmths128 prmths128 force-pushed the projects_public branch 5 times, most recently from c45d1cd to 1f2ea04 Compare January 19, 2025 16:22
@prmths128
feat(carbonserver) allow accessing public project data
318dec3 
Add public flag to project
Allow getting data for public project without authentication
@prmths128 prmths128 marked this pull request as ready for review January 19, 2025 16:25
@prmths128 prmths128 changed the title wip: allow accessing public project data allow accessing public project data Jan 19, 2025
@prmths128 prmths128 merged commit c257f4f into master Jan 19, 2025
9 checks passed
@prmths128 prmths128 deleted the projects_public branch January 19, 2025 17:09
inimaz
inimaz reviewed Jan 19, 2025
View reviewed changes
carbonserver/carbonserver/api/services/auth_context.py
if self._project_repository.is_project_public(project_id):
return True
if user is None:
raise Exception("Not authenticated")
Copy link
Contributor

@inimaz inimaz Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to know the full flow, why an exception instead of return False ? It will be caught later somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaboniAmine SaboniAmine SaboniAmine approved these changes

@inimaz inimaz inimaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prmths128 @SaboniAmine @inimaz