updating to 0.10

[brentp]

Hi, I am updating a project to mlua 0.10.3 from 0.9.9
The changeset is here: brentp/vcfexpress@main...mlua-0.10

I now get:

error in test_add_info: CallbackError { traceback: "stack traceback:\n\t[C]: in ?\n\t[string \"test_add_info\"]:2: in ?", cause: UserDataTypeMismatch }

In this test

The error occurs here at the call to: let this = ud.borrow_mut::<WrapHeaderView>()?;

Is there some other change that I need to make? Is there somehow AnyUserData or add_function_mut has changed?
thanks in advance.

[khvzak]

You wrapped your type to WrapHeaderView (which you don't have to!) and do mutually-exclusive things:

1. impl mlua::UserData for WrapHeaderView {}
2. lua.register_userdata_type::<WrapHeaderView>

it's a logic error.

The second things is, you still creating the old HeaderView instances:

• https://github.com/brentp/vcfexpress/blob/mlua-0.10/src/vcfexpress.rs#L177
• https://github.com/brentp/vcfexpress/blob/mlua-0.10/src/vcfexpress.rs#L336
• etc..

You need to either remove WrapHeaderView (go back to HeaderView) or ensure that only WrapHeaderView is used

[brentp]

Is there a problem with using impl mlua::UserData and lua.register_userdata_type?
I think I need to do this when the type is returned from another type.

e.g. here it returns a GTAllele which is registered with register_userdata_type but also seems to require impl mlua::UserData.

I'm not sure of that's related to the problem I have now that doing genotypes[i] gives: Err(RuntimeError("[string \"gts\"]:7: attempt to index Genotypes with number\nstack traceback:\n\t[C]: in ?\n\t[string \"gts\"]:7: in ?"))
for this test

[brentp]

... and thank you! removing the wrapper was indeed part of the problem.

[brentp]

hi @khvzak, could you give some guidance on this? See this comment (2 above)--where returning an registered type from a lua call no longer works the same way after updating to 0.10.3

[khvzak]

Is there a problem with using impl mlua::UserData and lua.register_userdata_type?

If you can implement UserData for your type, why would you need register_userdata_type ? You can add all methods to impl UserData.
You can redefine the same fn register method in UserData to manipulate UserDataRegistry

register_userdata_type was built for the case when you cannot implement UserData on foreign object because of Rust orphan rule.

[brentp]

Indeed, I can just use the impl UserData without register_userdate_type. thank you!

[brentp]

ok, I added that to alleviate another error.
I got that test to pass with this:
brentp/vcfexpress@10cd6cf
but I will remove the wrapper.

[brentp]

I removed the wrapper and indeed it's not needed.

I am having to use borrow_mut_scoped instead of borrow_mut. Here's a change for one method: brentp/vcfexpress@9b16ad9

I am using these inside of an outer scoped call, but this worked previously.

[khvzak]

I am having to use borrow_mut_scoped instead of borrow_mut.

Unfortunately borrow_mut was unsound in 0.9 in a scope (there are few corner cases when this can be misused) and I needed to change the API to make it sound.

[brentp]

it seems that even borrow is not working as before, I'm having to change to borrow_scoped