Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hints for attributes that are optional #127

Closed
OrangeTux opened this issue Oct 13, 2020 · 0 comments · Fixed by #132
Closed

Fix type hints for attributes that are optional #127

OrangeTux opened this issue Oct 13, 2020 · 0 comments · Fixed by #132
Assignees
@OrangeTux
Labels
enhancement New feature or request

Comments

@OrangeTux
Copy link
Contributor

Currently the classes as defined in ocpp.*.call and ocpp.*.call_result have optional attributes. But the type hints don't always reflect that.

For example:

@dataclass
class GetConfigurationPayload:
    key: List = None

This should become:

@dataclass
class GetConfigurationPayload:
    key: Optional[List] = None
@OrangeTux OrangeTux added the enhancement New feature or request label Oct 13, 2020
@OrangeTux OrangeTux self-assigned this Oct 14, 2020
@OrangeTux OrangeTux mentioned this issue Oct 14, 2020
Merged
OrangeTux added a commit that referenced this issue Oct 15, 2020
@OrangeTux
Fix 'Optional' type hints (#132)
d998865 
Fixes #127
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this issue Nov 26, 2024
@OrangeTux
Fix 'Optional' type hints (mobilityhouse#132)
a6b7f5d 
Fixes mobilityhouse#127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OrangeTux OrangeTux

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'Optional' type hints mobilityhouse/ocpp
1 participant
@OrangeTux