Fix validation of payloads containing floats #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepCode Report (#5fc60d)DeepCode analyzed this pull request. |
proelke
reviewed
Nov 14, 2019
ocpp/messages.py
Outdated
| @@ -32,7 +33,7 @@ def unpack(msg): | |||
| Unpacks a message into either a Call, CallError or CallResult. | |||
| """ | |||
| try: | |||
| msg = json.loads(msg) | |||
| msg = json.loads(msg, parse_float=decimal.Decimal) | |||
There was a problem hiding this comment.
Is it ok to always parse floats here but only schemas in a few instances?
There was a problem hiding this comment.
Good catch, I need to verify that.
There was a problem hiding this comment.
I started working on this a bit yesterday, and I got stuck on that part of porting the code over. If it's an issue I have an idea.
There was a problem hiding this comment.
I've removed the argument parse_float=decimal.Decimal. It is not needed in this place.
If a message requires special validation regarding the floats the message is reparsed again using parse_float=decimal.Decimal. See line 143 of this file.
OrangeTux
force-pushed
the
43-parse-float
branch
from
9a5a31f to
7d28d63
Compare
The validation of payloads using jsonschemas could fail when the payload contained a float. This problem is described in this issue: python-jsonschema/jsonschema#247 This commit implements a work around for this issue by changing the float parser for certain payloads from `float()` to `decimal.Decimal()`. Fixes: #43
OrangeTux
force-pushed
the
43-parse-float
branch
from
7d28d63 to
c2f3718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation of payloads using jsonschemas could fail when the payload
contained a float. This problem is described in this issue:
python-jsonschema/jsonschema#247
This commit implements a work around for this issue by changing the
float parser for certain payloads from
float()todecimal.Decimal().Fixes: #43