-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking change: remove deprecated Action items and update docs #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the name (and purpose) of the function _raise_key_error
, standard checking using if/else makes more sense. if using try/except blocks, then we should just remove this function and add this try/except to the calling code.
Need to update the following:
Let's create another PR for the doc changes. For the rest, let's update them in this PR itself. |
Just noticed your comment on a separate PR for doc changes, I've included them all in the above commit. Hopefully that's ok as then when this is merged all Action references are consistent. |
No worries. We can go with the doc changes in this PR itself. |
LGTM. @drc38, can you please update the description for the PR and include relevant changes done in this PR. |
HI @drc38, can you please rebase this with the master and update datatypes/enums used (if any). |
Master has been merged and tests are still passing. |
Changes included in this PR
Breaking change
As per the warning in 1.0.0 this PR removes deprecated Action items from the
enums.py
files to coincide with the 2.0.0 release, updates code references and updates documentation to be consistent with the change including string references.For example:
Action.BootNotification
withAction.boot_notification
@on("BootNotification")
andaction="BootNotification"
withAction.boot_notification
If users of the library have not already migrated to the new Action enums they will need to do so before using 2.0.0.
Checklist