Add support for Python 3.6 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2019 20:22
The project relies on the dataclasses package. This package is part of the stdlib as of Python 3.7. In order to support Python 3.6 this package must be installed from Pypi. This backport on Pypi doesn't work with Python 3.7. To quote the README from the package: "As of version 0.4, this code no longer works with Python 3.7. For 3.7, use the built-in dataclasses module." The traditional requirements file doesn't allow to install certain packages based on the Python version and don't install the package for other Python versions. Poetry does support exactly this. Poetry works with pyproject.toml that was proposed in PEP 518.
Roger
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project relies on the dataclasses package. This package is part of
the stdlib as of Python 3.7.
In order to support Python 3.6 this package must be installed from Pypi.
This backport on Pypi doesn't work with Python 3.7. To quote the README
from the package:
The traditional requirements file doesn't allow to install certain
packages based on the Python version and don't install the package for
other Python versions.
Poetry does support exactly this. Poetry works with pyproject.toml that
was proposed in PEP 518.
Fixes: #5