Add back support for azblob cache #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/project
area/testing
area/dependencies
|
@tonistiigi @crazy-max please take a look |
tonistiigi
reviewed
Feb 12, 2025
| } | ||
|
|
||
| // For uploading manifests, use the Upload API which follows "last writer wins" sematics | ||
| // This is slightly slower than UploadStream call but is safe to call concurrently from multiple threads. Refer to: |
There was a problem hiding this comment.
Do you need to check our UploadStream call in the gha backend?
There was a problem hiding this comment.
ok to do in a follow up PR? wanted to keep this limited to the vulnerability fixes so keeping everything else as it was. need to do some more testing (talking to azblob team) before changing this
| var _ io.ReadSeekCloser = &readSeekCloser{} | ||
|
|
||
| type readSeekCloser struct { | ||
| io.Reader |
There was a problem hiding this comment.
Why hide the other functions from interface detection? I would just embed *bytes.Reader and io.Closer
There was a problem hiding this comment.
wanted to keep the changes in this PR to a minimum and get the vulnerabilities unblocked, but open to changing. do you think a separate follow up PR is fine?
crazy-max
reviewed
Feb 12, 2025
tonistiigi
reviewed
Feb 13, 2025
Signed-off-by: Pranav Pandit <[email protected]>
vangarp
force-pushed
the
vangarp/azblob-cache-sdk-upgrade
branch
from
ab4fa88 to
1d5af10
Compare
tonistiigi
approved these changes
Feb 13, 2025
crazy-max
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add azblob cache back and fixes #5233